Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user validation popup for adding Asset #589

Open
peterjah opened this issue Aug 7, 2023 · 3 comments
Open

Add user validation popup for adding Asset #589

peterjah opened this issue Aug 7, 2023 · 3 comments

Comments

@peterjah
Copy link
Contributor

peterjah commented Aug 7, 2023

Context
Today, any dapp or software can add an asset in your massa wallet, just by calling an endpoint. It would make sense that user must confirm the add, to avoid spamming

todo:
Add a new wails workflow to confirm token addition. ( I think the password is not needed for this one)

@loonggamma
Copy link
Contributor

loonggamma commented Aug 22, 2023

Determine the flow here please @peterjah .
If I understand there are 2 ways of adding a token:
A) user manually via UI,
B) via API endpoint, a DApp can call it and add the token into user's assets, without user's permission (??)

If that's the case, we must create the confirmation only for B).

@loonggamma
Copy link
Contributor

@peterjah I need more details on this

@peterjah
Copy link
Contributor Author

peterjah commented Sep 22, 2023

there is only one way to add a token: calling the wallet api. the A) option is just a UI interface to do it. but it does option B) under the hood

@loonggamma loonggamma added should-have and removed P2 labels Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants