Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAQ - When can a transaction be considered failed? #291

Open
gregLibert opened this issue Mar 11, 2024 · 2 comments
Open

FAQ - When can a transaction be considered failed? #291

gregLibert opened this issue Mar 11, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@gregLibert
Copy link
Contributor

Add to the documentation an explanation of when a transaction can be definitively considered as failed. This includes the nominal case, where a transaction is included in a final block as failed, but also more exotic cases such as:

  • The transaction is not included in any block
  • The transaction is only included in a block that is stale
  • Other scenarios?
@gregLibert
Copy link
Contributor Author

gregLibert commented Mar 11, 2024

The expiration durations, in number of periods, for our various products should be aligned as much as possible. And documented.

As of today we have:

  • bridge: 9 periodes
  • massa station: 3
  • massa-web3: 5
  • node client: 10

@gregLibert gregLibert added the good first issue Good for newcomers label Mar 11, 2024
@damip
Copy link
Member

damip commented Mar 11, 2024

Note that the node client does not wait for the transaction. The 10 periods (not slots !!) you are referring to are the number of periods in the future that the expiry period of the transaction is set to when it is emitted. Is is set to 10 in order to match the validity duration of operations: https://github.com/massalabs/massa/blob/main/massa-models/src/config/constants.rs#L146

In general, waiting a constant time is not the right way to proceed as finality can take up to 1 cycle in practice.

Here is how to proceed: massalabs/massa-web3#472 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants