From c423b6ec2e40151c181cbf0a3ba1eed81ea216b2 Mon Sep 17 00:00:00 2001
From: Marshall Pierce <575695+marshallpierce@users.noreply.github.com>
Date: Sun, 24 Sep 2023 06:38:40 -0600
Subject: [PATCH] CI for all targets w/o default features

---
 .circleci/config.yml | 19 +++++++++++++++----
 Cargo.toml           |  3 +--
 2 files changed, 16 insertions(+), 6 deletions(-)

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 9e4b9ce..6a197d6 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -20,7 +20,7 @@ workflows:
               # get a nightly or stable toolchain via rustup instead of a mutable docker tag
               toolchain_override: [
                 '__msrv__', # won't add any other toolchains, just uses what's in the docker image
-                '1.60.0', # minimum needed to build dev-dependencies
+                '1.63.0', # minimum needed to build dev-dependencies
                 'stable',
                 'beta',
                 'nightly'
@@ -76,10 +76,20 @@ jobs:
             fi
       - run:
           name: Build without default features
-          command: cargo build --no-default-features
+          command: |
+            cargo build --no-default-features
+            if [[ '<< parameters.toolchain_override >>' != '__msrv__' ]]
+            then
+              cargo build --no-default-features --all-targets
+            fi
       - run:
           name: Build with only alloc
-          command: cargo build --no-default-features --features alloc
+          command: |
+            cargo build --no-default-features --features alloc
+            if [[ '<< parameters.toolchain_override >>' != '__msrv__' ]]
+            then
+              cargo build --no-default-features --features alloc --all-targets
+            fi
       - run:
           name: Add arm toolchain
           command: rustup target add thumbv6m-none-eabi
@@ -95,7 +105,8 @@ jobs:
           command: |
             if [[ '<< parameters.toolchain_override >>' != '__msrv__' ]]
             then
-              cargo test --verbose
+              cargo test --no-default-features
+              cargo test
             fi
       - run:
           name: Build docs
diff --git a/Cargo.toml b/Cargo.toml
index e906c1d..d7f1d76 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -10,7 +10,7 @@ keywords = ["base64", "utf8", "encode", "decode", "no_std"]
 categories = ["encoding"]
 license = "MIT OR Apache-2.0"
 edition = "2018"
-# dev-dependencies require 1.60, but the main code doesn't
+# dev-dependencies require 1.63, but the main code doesn't
 # This option was added in 1.56, keep it for when we bump MSRV.
 rust-version = "1.48.0"
 
@@ -37,7 +37,6 @@ rustdoc-args = ["--generate-link-to-definition"]
 [dev-dependencies]
 criterion = "0.4.0"
 rand = { version = "0.8.5", features = ["small_rng"] }
-# clap 4 would require 1.60
 structopt = "0.3.26"
 # test fixtures for engine tests
 rstest = "0.12.0"