- 28-Sept-2020: Initial Draft
- Anil Kumar (@anilcse)
- Jack Zampolin (@jackzampolin)
- Adam Bozanich (@boz)
Proposed
Currently in the SDK, events are defined in the handlers for each message as well as BeginBlock and EndBlock. Each module doesn't have types defined for each event, they are implemented as map[string]string. Above all else this makes these events difficult to consume as it requires a great deal of raw string matching and parsing. This proposal focuses on updating the events to use typed events defined in each module such that emiting and subscribing to events will be much easier. This workflow comes from the experience of the Akash Network team.
Currently in the SDK, events are defined in the handlers for each message, meaning each module doesn't have a cannonical set of types for each event. Above all else this makes these events difficult to consume as it requires a great deal of raw string matching and parsing. This proposal focuses on updating the events to use typed events defined in each module such that emiting and subscribing to events will be much easier. This workflow comes from the experience of the Akash Network team.
Our platform requires a number of programatic on chain interactions both on the provider (datacenter - to bid on new orders and listen for leases created) and user (application developer - to send the app manifest to the provider) side. In addition the Akash team is now maintaining the IBC relayer, another very event driven process. In working on these core pieces of infrastructure, and integrating lessons learned from Kubernetes developement, our team has developed a standard method for defining and consuming typed events in SDK modules. We have found that it is extremely useful in building this type of event driven application.
As the SDK gets used more extensively for apps like peggy, other peg zones, IBC, DeFi, etc... there will be an exploding demand for event driven applications to support new features desired by users. We propose upstreaming our findings into the SDK to enable all SDK applications to quickly and easily build event driven apps to aid their core application. Wallets, exchanges, explorers, and defi protocols all stand to benefit from this work.
If this proposal is accepted, users will be able to build event driven SDK apps in go by just writing EventHandlers for their specific event types and passing them to EventEmitters that are defined in the SDK.
The end of this proposal contains a detailed example of how to consume events after this refactor.
This proposal is specifically about how to consume these events as a client of the blockchain, not for intermodule communication.
Step-1: Implement additional functionality in the types package: EmitTypedEvent and ParseTypedEvent functions
// types/events.go
// EmitTypedEvent takes typed event and emits converting it into sdk.Event
func (em *EventManager) EmitTypedEvent(event proto.Message) error {
evtType := proto.MessageName(event)
evtJSON, err := codec.ProtoMarshalJSON(event)
if err != nil {
return err
}
var attrMap map[string]json.RawMessage
err = json.Unmarshal(evtJSON, &attrMap)
if err != nil {
return err
}
var attrs []abci.EventAttribute
for k, v := range attrMap {
attrs = append(attrs, abci.EventAttribute{
Key: []byte(k),
Value: v,
})
}
em.EmitEvent(Event{
Type: evtType,
Attributes: attrs,
})
return nil
}
// ParseTypedEvent converts abci.Event back to typed event
func ParseTypedEvent(event abci.Event) (proto.Message, error) {
concreteGoType := proto.MessageType(event.Type)
if concreteGoType == nil {
return nil, fmt.Errorf("failed to retrieve the message of type %q", event.Type)
}
var value reflect.Value
if concreteGoType.Kind() == reflect.Ptr {
value = reflect.New(concreteGoType.Elem())
} else {
value = reflect.Zero(concreteGoType)
}
protoMsg, ok := value.Interface().(proto.Message)
if !ok {
return nil, fmt.Errorf("%q does not implement proto.Message", event.Type)
}
attrMap := make(map[string]json.RawMessage)
for _, attr := range event.Attributes {
attrMap[string(attr.Key)] = attr.Value
}
attrBytes, err := json.Marshal(attrMap)
if err != nil {
return nil, err
}
err = jsonpb.Unmarshal(strings.NewReader(string(attrBytes)), protoMsg)
if err != nil {
return nil, err
}
return protoMsg, nil
}Here, the EmitTypedEvent is a method on EventManager which takes typed event as input and apply json serialization on it. Then it maps the JSON key/value pairs to event.Attributes and emits it in form of sdk.Event. Event.Type will be the type URL of the proto message.
When we subscribe to emitted events on the tendermint websocket, they are emitted in the form of an abci.Event. ParseTypedEvent parses the event back to it's original proto message.
Step-2: Add proto definitions for typed events for msgs in each module:
For example, let's take MsgSubmitProposal of gov module and implement this event's type.
// proto/cosmos/gov/v1beta1/gov.proto
// Add typed event definition
package cosmos.gov.v1beta1;
message EventSubmitProposal {
string from_address = 1;
uint64 proposal_id = 2;
TextProposal proposal = 3;
}Step-3: Refactor event emission to use the typed event created and emit using sdk.EmitTypedEvent:
// x/gov/handler.go
func handleMsgSubmitProposal(ctx sdk.Context, keeper keeper.Keeper, msg types.MsgSubmitProposalI) (*sdk.Result, error) {
...
types.Context.EventManager().EmitTypedEvent(
&EventSubmitProposal{
FromAddress: fromAddress,
ProposalId: id,
Proposal: proposal,
},
)
...
}NOTE: Full code example below
Users will be able to subscribe using client.Context.Client.Subscribe and consume events which are emitted using EventHandlers.
Akash Network has built a simple pubsub. This can be used to subscribe to abci.Events and publish them as typed events.
Please see the below code sample for more detail on this flow looks for clients.
- Improves consistency of implementation for the events currently in the sdk
- Provides a much more ergonomic way to handle events and facilitates writing event driven applications
- This implementation will support a middleware ecosystem of
EventHandlers
This ADR also proposes adding affordances to emit and consume these events. This way developers will only need to write
EventHandlers which define the actions they desire to take.
// EventEmitter is a type that describes event emitter functions
// This should be defined in `types/events.go`
type EventEmitter func(context.Context, client.Context, ...EventHandler) error
// EventHandler is a type of function that handles events coming out of the event bus
// This should be defined in `types/events.go`
type EventHandler func(proto.Message) error
// Sample use of the functions below
func main() {
ctx, cancel := context.WithCancel(context.Background())
if err := TxEmitter(ctx, client.Context{}.WithNodeURI("tcp://localhost:26657"), SubmitProposalEventHandler); err != nil {
cancel()
panic(err)
}
return
}
// SubmitProposalEventHandler is an example of an event handler that prints proposal details
// when any EventSubmitProposal is emitted.
func SubmitProposalEventHandler(ev proto.Message) (err error) {
switch event := ev.(type) {
// Handle governance proposal events creation events
case govtypes.EventSubmitProposal:
// Users define business logic here e.g.
fmt.Println(ev.FromAddress, ev.ProposalId, ev.Proposal)
return nil
default:
return nil
}
}
// TxEmitter is an example of an event emitter that emits just transaction events. This can and
// should be implemented somewhere in the SDK. The SDK can include an EventEmitters for tm.event='Tx'
// and/or tm.event='NewBlock' (the new block events may contain typed events)
func TxEmitter(ctx context.Context, cliCtx client.Context, ehs ...EventHandler) (err error) {
// Instantiate and start tendermint RPC client
client, err := cliCtx.GetNode()
if err != nil {
return err
}
if err = client.Start(); err != nil {
return err
}
// Start the pubsub bus
bus := pubsub.NewBus()
defer bus.Close()
// Initialize a new error group
eg, ctx := errgroup.WithContext(ctx)
// Publish chain events to the pubsub bus
eg.Go(func() error {
return PublishChainTxEvents(ctx, client, bus, simapp.ModuleBasics)
})
// Subscribe to the bus events
subscriber, err := bus.Subscribe()
if err != nil {
return err
}
// Handle all the events coming out of the bus
eg.Go(func() error {
var err error
for {
select {
case <-ctx.Done():
return nil
case <-subscriber.Done():
return nil
case ev := <-subscriber.Events():
for _, eh := range ehs {
if err = eh(ev); err != nil {
break
}
}
}
}
return nil
})
return group.Wait()
}
// PublishChainTxEvents events using tmclient. Waits on context shutdown signals to exit.
func PublishChainTxEvents(ctx context.Context, client tmclient.EventsClient, bus pubsub.Bus, mb module.BasicManager) (err error) {
// Subscribe to transaction events
txch, err := client.Subscribe(ctx, "txevents", "tm.event='Tx'", 100)
if err != nil {
return err
}
// Unsubscribe from transaction events on function exit
defer func() {
err = client.UnsubscribeAll(ctx, "txevents")
}()
// Use errgroup to manage concurrency
g, ctx := errgroup.WithContext(ctx)
// Publish transaction events in a goroutine
g.Go(func() error {
var err error
for {
select {
case <-ctx.Done():
break
case ed := <-ch:
switch evt := ed.Data.(type) {
case tmtypes.EventDataTx:
if !evt.Result.IsOK() {
continue
}
// range over events, parse them using the basic manager and
// send them to the pubsub bus
for _, abciEv := range events {
typedEvent, err := sdk.ParseTypedEvent(abciEv)
if err != nil {
return er
}
if err := bus.Publish(typedEvent); err != nil {
bus.Close()
return
}
continue
}
}
}
}
return err
})
// Exit on error or context cancelation
return g.Wait()
}