Delay loading of tile stamps until after initializing the session #4044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (5)
- src/tiled/mainwindow.cpp: Language not supported
- src/tiled/projectmanager.cpp: Language not supported
- src/tiled/projectmanager.h: Language not supported
- src/tiled/tilestampmanager.cpp: Language not supported
- src/tiled/tilestampmanager.h: Language not supported
Oh well, that's disappointing. |
The tilesets referenced by stored tile stamps may rely on custom types defined in the project and possibly even on custom tileset formats added by extensions. Hence, it is better to wait with loading them until after the project has been loaded and script manager is initialized. The user will still run into issues when the project isn't loaded on startup, but this at least makes running into issues less likely. It could help to force reloading of the stamps when switching projects.
bjorn
force-pushed
the
delay-load-tile-stamps
branch
from
f64cef1 to
2e9e9ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tilesets referenced by stored tile stamps may rely on custom types defined in the project and possibly even on custom tileset formats added by extensions. Hence, it is better to wait with loading them until after the project has been loaded and script manager is initialized.
The user will still run into issues when the project isn't loaded on startup, but this at least makes running into issues less likely.
It could help to force reloading of the stamps when switching projects.