Fixed the entry limit for enums used as flags to be 31 #3666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As noted by @eishiya, the expected maximum number of supported flags is actually 31, so we still need to do some research on why the problems already start at 31 flags. The documentation added in 2a8fc6e should also be clarified, since contrary to what I wrote in the commit message, the value of the 31st flag should actually be 1073741824 (2^30), given that the 1st flag has value 1 (2^0). |
Previously it could only handle 30 flags due to a check that was done using signed integers.
This was already working, but the test is just making sure they are indeed saved and loaded correctly.
bjorn
changed the title
Due to the use of a 32-bit int to store the flags, the maximum number of flags is actually 31 rather than 32. When more entries are added, the editing of enum values breaks entirely. The translations have been updated to use a parameter for the maximum number of flags in an enum, to make it easier to adjust this value when it might be increased in the future. Closes mapeditor#3658
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the use of a 32-bit int to store the flags, the maximum number of flags is actually 30 rather than 32. When more entries are added, the editing of enum values breaks entirely.
The translations have been updated to use a parameter for the maximum number of flags in an enum, to make it easier to adjust this value when it might be increased in the future.
Closes #3658