-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change behavior: Rotate and flip Objects before placement. #3091
Comments
The flip and rotate actions currently always apply to the selected objects, but with your suggestion they should instead apply to the preview while placing an object. I think that makes a lot of sense. |
Great! I would love to see that implemented. |
The flip/rotate will now always apply to the preview, even if it is not currently active, rather than applying to the selection (usually the last placed object) in that case. If you want to actually flip or rotate the selection, you now need to exit the placement tool (can be done by Escape, for example). I think this is not a huge loss, because it makes the transformation actions more consistent and enables clicking the tool bar buttons to activate them. Issue #3091
@UliAbo In my initial implementation, the transformation actions did not apply to the preview when it wasn't there (so, when the mouse wasn't over the map). The main problem with this was that clicking the tool bar buttons would not work (it would still only apply to the selection). I've now pushed a follow-up change, that makes the behavior consistently affect the preview as long as the placement tool is selected, which I think is a preferable behavior. And thanks for bringing this up, I think it was a good improvement! |
I'm glad to see this now in action in Tiled v1.8, that feels really good! |
Because of this change, it is now no longer impossible to flip the placed object after the fact even though it's selected as if it can be edited. The user must press Esc first, which will "finish" placing the object and take them to Select Objects mode. Reported on the forum: https://discourse.mapeditor.org/t/request-new-feature/5449 (point 4) Perhaps the new object's properties should show up in the properties panel for editing, but the object shouldn't show up as selected, so that it's clearer that flipping will not affect the placed object? |
Very good observed, I didn't notice that for now. |
I think newly placed objects should be selected, but maybe the selection just appears too "active". What if we would only show the full animated selection outline when the "Select Objects" tool is selected, and showing the "hover" version otherwise? |
Just to understand it better - why is it good to have it selected? To quickly see the properties or is there another reason? EDIT: AsIs:
ToBe:
What do you think? :-) I can post this as a separated issue. |
I probably thought it was expected and helpful behavior, since it is also done by Inkscape for example and it allows immediately editing the object's properties after placement without requiring to switch tools and then select the just placed object. Tiled behaves this way since Tiled 0.13 (2b0313b), but unfortunately I didn't provide any context for this change.
Well, this is indeed rather unrelated behavior, but I don't think this suggestion would really work. The Properties view displays the properties of the last clicked / selected thing. If you deselect something, without selecting something else, there is no way for it to know what it should display. It could switch to anything (currently selected tile (like you're suggesting), currently selected layer, current map, etc.). So personally I think the choice is mainly between displaying nothing or to keep displaying the last clicked / selected thing (current behavior). |
Maybe we have a misunderstanding here :-) |
You can't choose a "tile object" from the Tilesets view. When you click something there, the displayed properties are those of the selected tile. The Properties view can't display the properties of objects that have not been created yet.
How would we decide which fallback to pick? Why would we make the last selected tile the current object again, rather than say, the selected layer, terrain set / type or the map itself? |
Goal:
AsIs:
ToBe:
I'm looking forward to your feedback :)
The text was updated successfully, but these errors were encountered: