Handle rare case on packet pipeline #2450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix mamoe#2449, should help mamoe#1603
Karlatemp
reviewed
Jan 22, 2023
mirai-core/src/commonMain/kotlin/network/components/PacketCodec.kt
Outdated
Show resolved
Hide resolved
mirai-core/src/commonMain/kotlin/network/components/PacketCodec.kt
Outdated
Show resolved
Hide resolved
mirai-core/src/commonMain/kotlin/network/components/PacketCodec.kt
Outdated
Show resolved
Hide resolved
|
自动收集上报私人信息，或者加密日志都是绝对不行的 |
不是自动上报，是由用户自己填写公钥（不写就是明文），然后再进行导出吧？公钥相当于收件人了其实，没那么敏感。 |
|
可以直接将敏感信息直接输出到日志里面 |
Him188
reviewed
Feb 3, 2023
mirai-core/src/commonMain/kotlin/network/components/PacketCodec.kt
Outdated
Show resolved
Hide resolved
|
我的想法就是在提供个如何加密日志的方法，让用户自己加密然后报告 |
Co-authored-by: Him188 <[email protected]>
Him188
approved these changes
Feb 19, 2023
Karlatemp
reviewed
Feb 19, 2023
mirai-core/src/commonMain/kotlin/network/components/PacketCodec.kt
Outdated
Show resolved
Hide resolved
mirai-core/src/commonMain/kotlin/network/components/PacketCodec.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # mirai-core/src/commonMain/kotlin/network/components/PacketCodec.kt
StageGuard
pushed a commit
to StageGuard/mirai
that referenced
this pull request
Apr 14, 2023
* Handle rare case on packet pipeline Fix mamoe#2449, should help mamoe#1603 * Fix and improve tips and improve the readability of code * Improve wording of tips Co-authored-by: Him188 <[email protected]> * Change d2Key error type to PROTOCOL_UPDATED * Reformat code --------- Co-authored-by: Him188 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2449, should help #1603
另：考虑到情况的极其罕见性，对未知数据包尝试进行了解密，但如果用户报告含有解密包内容的日志，可能会涉及到账号相关的token泄漏，需要考虑安全性的问题（在报告之前给机器人改个密码？