Sync remotes #15
Open
Sync remotes #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperSandro2000
force-pushed
the
sync-remotes
branch
from
514bea8 to
3a1294e
Compare
This makes things obvious in case a remote name is remote or has
SuperSandro2000
force-pushed
the
sync-remotes
branch
from
3a1294e to
b011484
Compare
|
@majewsky ping |
majewsky
requested changes
Jul 8, 2024
| @@ -381,7 +465,7 @@ func (i *Index) ImportRepo(dirPath string) error { | |||
| return errors.New("repo has no remotes") | |||
| } | |||
|
|
|||
| question := fmt.Sprintf("Repo has multiple remotes. Where to put below %s?", RootPath) | |||
| question := fmt.Sprintf(`Repo has multiple remotes. Where to put below "%s"?`, RootPath) | |||
There was a problem hiding this comment.
Suggested change
| question := fmt.Sprintf(`Repo has multiple remotes. Where to put below "%s"?`, RootPath) | |
| question := fmt.Sprintf("Repo has multiple remotes. Where to put below %q?", RootPath) |
|
|
||
| // ask the user what to do with remotes not existing in checked out repo | ||
| selection, err := cli.Interface.Query( | ||
| fmt.Sprintf(`repository "%s" remote "%s" has been deleted`, repo.AbsolutePath(), remote.Name), |
There was a problem hiding this comment.
Suggested change
| fmt.Sprintf(`repository "%s" remote "%s" has been deleted`, repo.AbsolutePath(), remote.Name), | |
| fmt.Sprintf(`repository %q remote %q has been deleted`, repo.AbsolutePath(), remote.Name), |
Also, I suggest the clearer phrasing remote %q of repository %q has been deleted.
| toUpdate = append(toUpdate, remote.Name) | ||
| newRemotes = append(newRemotes, remote) | ||
| case "d": | ||
| case "s": |
There was a problem hiding this comment.
s should add the remote to the new list, i.e. effectively not touch it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting a remote that is registered in the index, rtree now asks what to do with it like when encountering a deleted repo.
Closes #11