Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracker3: fix compiler choice #27077

Merged
merged 1 commit into from
Dec 14, 2024
Merged

tracker3: fix compiler choice #27077

merged 1 commit into from
Dec 14, 2024

Conversation

barracuda156
Copy link
Contributor

@barracuda156 barracuda156 commented Dec 14, 2024

Description

Unbreak the build after 49a25be

The port does not need C++11, however it uses C11 features and fails to build with a C99 compiler.

P. S. @mohd-akram @kencu If you consider that the failure is not due to C11 being required, alternative fix would be to blacklist Xcode gcc, since MacPorts considers it to be C99-capable, and it fails to build this port. So what we have now is wrong in any case.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6
Xcode 3.2

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@kencu
Copy link
Contributor

kencu commented Dec 14, 2024

redefinition of typedefs is a C11 feature, certainly.

The buildbot failures seen on macports buildbots are coming from a lack of ‘openat’ on some systems, so the use of legacysupport apparently needs to be broadened upward to replace this function.

@kencu
Copy link
Contributor

kencu commented Dec 14, 2024

fixed openat here, hopefully:

7376c12

@kencu kencu merged commit e1b9b5d into macports:master Dec 14, 2024
3 checks passed
@barracuda156 barracuda156 deleted the tracker3 branch December 14, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants