Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mlterm: misc improvements, revbump #27034

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

barracuda156
Copy link
Contributor

Description

Sort out dependencies, fix config args for fribidi variant, add support for images rendering via libsixel.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6
Xcode 3.2

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@barracuda156
Copy link
Contributor Author

I do not know what this means and why this fails:

  --->  Patching bl_time.c: s|/usr/local|/opt/local|g
  DEBUG: Executing reinplace: /usr/bin/sed s|/usr/local|/opt/local|g </opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_x11_mlterm/mlterm/work/mlterm-3.9.3/baselib/src/bl_time.c >@file11
  sed: RE error: illegal byte sequence
  DEBUG: child process exited abnormally
      while executing
  "exec -ignorestderr -- {*}$cmdline"
  Error: reinplace: child process exited abnormally
  Error: Failed to patch mlterm: reinplace sed(1) failed
  DEBUG: Error code: NONE
  DEBUG: Backtrace: reinplace sed(1) failed

I can just drop that part, it is not strictly necessary, just was a matter of safety (to avoid pulling in wrong stuff). On buildbots that is not an issue, since /usr/local supposed to be absent.

@barracuda156
Copy link
Contributor Author

@herbygillot @reneeotten This should be good to merge, I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants