feat: Added hint_timeout option to hide hints after a delay #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Sawangg, Thanks for picking up this issue! I tested it out and found that your implementation doesn't work with nvim-notify. Instead of clearing the last notification, it sends a new blank notification, as shown here:
The primary goal of #82 is to work with nvim-notify, as the UI-style notification is annoying if it stays too long. For native text notifications, a timeout mechanism isn't needed since it doesn't block anything. Sorry for the unclear issue description. If you have any further questions, feel free to ask! |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@m4xshen This PR adds a
hint_timeoutoption with a default value of5000to hide hints after a delay.This addresses issue #82. This implementation resets the timeout back to its original value if a new hint comes in before the last timeout was executed.
Feel free to edit the default value if
5000is not to your taste but it seems like a good middle ground in my tests.