Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications System #891

Closed
5 tasks
nylira opened this issue Jun 27, 2018 · 5 comments
Closed
5 tasks

Notifications System #891

nylira opened this issue Jun 27, 2018 · 5 comments
Labels
epic low priority has been discussed, will be addressed later split 🍌 issues that need to be split into several smaller issues with reduced scope

Comments

@nylira
Copy link
Contributor

nylira commented Jun 27, 2018

UI Version: 0.7.0

Description: It would be useful to have a toggleable notifications slide-out menu, so users can close notifications without losing them forever.

  • notifications button in the top right corner of the app that toggles a notifications modal, and shows a red dot with # of new notifications
  • new notifications menu that takes up 100% of the screen on mobile, and 25% of the screen in desktop. It should be attached to the right side of the screen.
  • allow the user to clear all notifications from the menu
  • update error notifications to disappear after a few seconds, instead of persisting forever
  • send all notifications to the notifications menu after a few seconds
@nylira
Copy link
Contributor Author

nylira commented Jun 27, 2018

Or instead of recreating a notification system, we just use Electron's support for OS notifications. This would also relate directly to #808, a voyager daemon.

I know that @faboweb is against using electron-related features, but if we decided to go with browser-based Voyager later, we can port the notifications over the browser using https://developer.mozilla.org/en-US/docs/Web/API/notification

@nylira nylira changed the title Notifications Slide-Out Menu Notifications System Jun 27, 2018
@faboweb
Copy link
Collaborator

faboweb commented Jul 2, 2018

Why not directly use web notifications? It should work from within Electron. But I am not sure if there is a default web notification history for Windows/Linux. (https://electronjs.org/docs/tutorial/notifications)

@jbibla
Copy link
Collaborator

jbibla commented Jul 3, 2018

notifications button in the top right corner of the app that toggles a notifications modal, and shows a red dot with # of new notifications

this sounds great.

new notifications menu that takes up 100% of the screen on mobile, and 25% of the screen in desktop. It should be attached to the right side of the screen.

i would prefer if this was a notifications page instead of a modal. this, like the tx history is something we would want people to be able to visit and use as a historical reference. modals tend to be more fleeting / don't imply the type of persistence i would hope for.

allow the user to clear all notifications from the menu

hmm. maybe we need to define the types of notifications we're talking about here...

update error notifications to disappear after a few seconds, instead of persisting forever

i think there is a difference between cosmos specific notifications like "one of the validators you've bonded too is no longer a validator" and console errors. should we consider cosmos-notifications being included in the tx history somehow?

send all notifications to the notifications menu after a few seconds

i would assume that notifications would appear "on the notifications page / menu" instantly - with this kind of page perhaps we don't need the error-modals at all.

@faboweb
Copy link
Collaborator

faboweb commented Jul 4, 2018

i think there is a difference between cosmos specific notifications like "one of the validators you've bonded too is no longer a validator" and console errors. should we consider cosmos-notifications being included in the tx history somehow?

Would this overload the tx history? If we overload it too much, users might get information blindness and miss critical information. This is why I tend more to a dashboard of some kind, which shows data more structured.

@jbibla
Copy link
Collaborator

jbibla commented Jul 6, 2018

that's a fair point.

i think we need a list of tx types, cosmos-notifications, and types of errors that appear in the current error modals. then we can see what the best design would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic low priority has been discussed, will be addressed later split 🍌 issues that need to be split into several smaller issues with reduced scope
Projects
None yet
Development

No branches or pull requests

4 participants