Proposal description max length should match the max length set in the SDK

[jbibla]

it would be nice if this matched the size from the SDK. but we can adjust later.

Originally posted by @jbibla in #1807

[faboweb]

Chris mentioned that there is only an implicit max length.

[jbibla]

implicit max length.

what does that mean?

[faboweb]

#1807 (comment)

There is only a max length per transaction in total.

[jbibla]

what is it? let's ensure that the description field is as large as can be to fit within this limit.

[faboweb]

@cwgoes what is the max size of tx?

The max length of a description is the max size of the tx minus the length of the title minus the length of the fees string etc. etc.
Hard to calc. We can add a max length that is defensive.

[cwgoes]

I am not sure the SDK will directly enforce a maximum size (Tendermint does, but it is quite high) - rather, the maximum size will be set implicitly by a gas limit and gas charged proportional to size.

We can very easily add a separate maximum length just for validator descriptions, and that probably makes sense from the UX perspective too: cosmos/cosmos-sdk#3420 - if you would like a particular maximum length, please comment.

[faboweb]

Thx @cwgoes for creating the issue.

[faboweb]

Maybe subtract a heuristic of the size of the rest of the transaction from the max transaction size. @ebuchman what is the max transaction size?

[sabau]

Just as reminder @jbibla made a nice experiment with 2 messages of length:

• 10000 throwed error
• 5000 worked

[fedekunze]

new length limits are:

MaxDescriptionLength = 5000
MaxTitleLength = 140