Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Language Improvements #1365

Closed
faboweb opened this issue Sep 26, 2018 · 15 comments
Closed

General Language Improvements #1365

faboweb opened this issue Sep 26, 2018 · 15 comments
Labels
design-work-needed 🎨 issues that require design work before development

Comments

@faboweb
Copy link
Collaborator

faboweb commented Sep 26, 2018

The validators on the my stake page are not unstaked, they are currently unstaking.

image

@faboweb faboweb added discuss design-work-needed 🎨 issues that require design work before development labels Sep 26, 2018
@jbibla
Copy link
Collaborator

jbibla commented Sep 26, 2018

i think we're going with unbonded @fedekunze @rigelrozanski is that correct?

so maybe a good title would be Currently Undbonding - these should likely also show the dates 📅

@rigelrozanski
Copy link

rigelrozanski commented Sep 27, 2018

Validators tokens' can be bonded, unbonding, or unbonded

Delegators tokens can be delegated or undelegated in ADDITION to being bonded, unbonding, or unbonded

@jbibla
Copy link
Collaborator

jbibla commented Sep 27, 2018

@rigelrozanski should we avoid calling this the Staking section or the My Stake tab?

@rigelrozanski
Copy link

rigelrozanski commented Sep 27, 2018

IMO I would remove all reference to the word "stake" in the UI - I find it confusing - alternatively (IMO less desirable) we could remove absolutely all reference to the word bond and replace it with stake (aka we would now use staked, unstaking, or unstaked) - I don't think we should do the latter

@rigelrozanski
Copy link

rigelrozanski commented Sep 27, 2018

side thought - I wonder if we should rename the staking module (which is the only use of the word stake in the sdk) to bondage - it's kinda confusing because the module deals with both bonding and delegations - not sure... maybe this should still be the one use case for the word staking; the system of bonding and delegating

@faboweb
Copy link
Collaborator Author

faboweb commented Sep 28, 2018

I wonder if we should rename the staking module to bondage

Let's not go there. This will be weird for developers. And we don't want to be seen as weird, we want to show trust in our code and in our platform.

@NodeGuy NodeGuy changed the title Rename Unstaked Validators to Unstaking Rename Unstaked Validators to "Undelegating Validators" Oct 2, 2018
@NodeGuy
Copy link
Contributor

NodeGuy commented Oct 2, 2018

We agreed in the meeting to change the header to Undelegating Validators in staking1.

@faboweb faboweb removed the discuss label Oct 2, 2018
@rigelrozanski
Copy link

rigelrozanski commented Oct 2, 2018

@NodeGuy (CC @faboweb @jbibla )

The language just suggested is inconsistent with how staking works (and is oxymoronic in the context of how we use the terms). - please refer to some of the original language discussions - #1283 (comment)

The validator object does not itself delegate (however the operator of the validator does have a self-delegation) - there are a number of different situations which will cause the validator's tokens to move from the bonded state to an unbonding state - the most correct term to use to describe what you are getting at is unbonding validator

@faboweb
Copy link
Collaborator Author

faboweb commented Oct 3, 2018

We want to avoid the use of the word bonding to not confuse users. Anyway undelegating validator is temporary and will be replaced by undelgation transactions.

@jbibla jbibla changed the title Rename Unstaked Validators to "Undelegating Validators" General Language Improvements Oct 9, 2018
@jbibla
Copy link
Collaborator

jbibla commented Oct 9, 2018

takeaways from the call with @faboweb and @rigelrozanski :

General

  • not going to use Bonding, Bonded, Unbonding (the B words) to communicate token state. instead we will imply this with the action words - Delegation and associated terms

TmBalance

  • change "Unbonded" to "Available"

LiValidator and PageValidator

  • display three status' / states (Active, Jailed, Inactive)

My Delegations Tab

  • “Bonded Steak” filter is technically innaccurate - replace with "Delegated Steak"
  • display two lists: "Active Delegations" and "Inactive Delegations"

@rigelrozanski
Copy link

Thanks for the writeup @jbibla - p.s. we should probably update to use stake as per the new plan with Game of Stakes

@jbibla
Copy link
Collaborator

jbibla commented Oct 9, 2018

thank you for the time and ideas!

this is being tracked separately #1378.

@NodeGuy
Copy link
Contributor

NodeGuy commented Oct 10, 2018

Thank you, @jbibla. Would you please put that somewhere that's easy to find, like a Google Doc? I imagine we're going to need to reference it frequently in the future.

@faboweb
Copy link
Collaborator Author

faboweb commented Oct 10, 2018

Great idea

@rigelrozanski
Copy link

rigelrozanski commented Oct 10, 2018

May I suggest a docs section in the voyager repo to house the most updated language decisions/discussions? - we use a docs/ folder in the sdk and it's fantastic, things never get lost hehe

@jbibla jbibla mentioned this issue Oct 10, 2018
6 tasks
@faboweb faboweb closed this as completed Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-work-needed 🎨 issues that require design work before development
Projects
None yet
Development

No branches or pull requests

4 participants