-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add node prefix import for Deno support #212
Conversation
nvm i could |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging despite the failing tests.
Future releases will continue to include the node:
prefixes for import
conditions, but omit the prefixes for require
(CommonJS) conditions. This will maximize backwards Node compat, since below 14 will more than likely not understand exports
maps and not find the import
entries anyway
It is OK to add the node: prefix, but please update the major version number to 2.x. The current release is a breaking change for existing applications. |
The This is also why you install polka via Apologies about the breaking change, but working on finding a working solution for modern and more legacy codebases. It'd help if you provided information in the issue, not here. |
Dependency:
The question is: why does sirv depend on the next version of @polka/url, but the stable version? And it seems that the sirv package is also maintained by you. |
|
tests don't pass because of standard-things/esm#904