Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add node prefix import for Deno support #212

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

benmccann
Copy link

@benmccann benmccann commented Sep 3, 2024

tests don't pass because of standard-things/esm#904

@lukeed
Copy link
Owner

lukeed commented Sep 4, 2024

Sorry, can you remove the eslint stuff

nvm i could

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Owner

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging despite the failing tests.

Future releases will continue to include the node: prefixes for import conditions, but omit the prefixes for require (CommonJS) conditions. This will maximize backwards Node compat, since below 14 will more than likely not understand exports maps and not find the import entries anyway

@lukeed lukeed merged commit e34ad69 into lukeed:next Sep 18, 2024
0 of 5 checks passed
@xqin
Copy link

xqin commented Sep 19, 2024

It is OK to add the node: prefix, but please update the major version number to 2.x.

The current release is a breaking change for existing applications.

@lukeed
Copy link
Owner

lukeed commented Sep 19, 2024

The next track of Polka is "next" -- it's not stable release yet. In fact, next is targeted to be the 1.0 release.
The master / stable branch is currently 0.5.x

This is also why you install polka via polka@next -- you're opting into the next release channel.

Apologies about the breaking change, but working on finding a working solution for modern and more legacy codebases. It'd help if you provided information in the issue, not here.

@xqin
Copy link

xqin commented Sep 19, 2024

The next track of Polka is "next" -- it's not stable release yet. In fact, next is targeted to be the 1.0 release. The master / stable branch is currently 0.5.x

This is also why you install polka via polka@next -- you're opting into the next release channel.

Apologies about the breaking change, but working on finding a working solution for modern and more legacy codebases. It'd help if you provided information in the issue, not here.

Dependency:

[email protected]  -> sirv@^2.0.3 -> @polka/url^1.0.0-next.24

The question is: why does sirv depend on the next version of @polka/url, but the stable version?

And it seems that the sirv package is also maintained by you.

@lukeed
Copy link
Owner

lukeed commented Sep 19, 2024

It'd help if you provided information in the issue, not here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants