replace the RWMutex with a Mutex in the flow controller #2865
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obviously, the RW feature of the mutex was not used at all.
The mutex is needed because the
Read
go routines on multiple streams will callAddBytesRead
. However, this is a write access. The only read access we have here is from the session go routine asking for flow control updates. An RW mutex however only makes sense if you have multiple go routines performing read access.