Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait until the handshake is complete before updating the connection ID #2856

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

marten-seemann
Copy link
Member

This is not required anywhere, but we don't need to unnecessarily complicate things.

@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #2856 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2856      +/-   ##
==========================================
+ Coverage   85.67%   85.68%   +0.01%     
==========================================
  Files         134      134              
  Lines        9087     9091       +4     
==========================================
+ Hits         7785     7789       +4     
  Misses        960      960              
  Partials      342      342              
Impacted Files Coverage Δ
conn_id_manager.go 93.55% <100.00%> (+0.22%) ⬆️
session.go 77.27% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 272229a...80534c0. Read the comment docs.

@marten-seemann marten-seemann merged commit 3cd8b30 into master Nov 10, 2020
@marten-seemann marten-seemann deleted the conn-id-update-handshake-completion branch November 11, 2020 09:25
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants