Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error handling when receiving post handshake messages #2807

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

marten-seemann
Copy link
Member

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=26021.
Looks like this is a regression introduced by #2802.

@marten-seemann marten-seemann force-pushed the fix-post-handshake-message-error-handling branch from d86aa2c to 2e56f76 Compare September 28, 2020 03:51
@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #2807 into master will decrease coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2807      +/-   ##
==========================================
- Coverage   85.92%   85.92%   -0.01%     
==========================================
  Files         133      133              
  Lines       12075    12077       +2     
==========================================
+ Hits        10375    10376       +1     
- Misses       1365     1366       +1     
  Partials      335      335              
Impacted Files Coverage Δ
internal/handshake/crypto_setup.go 65.08% <75.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebe051b...6ad29e7. Read the comment docs.

@marten-seemann marten-seemann force-pushed the fix-post-handshake-message-error-handling branch from 2e56f76 to 6ad29e7 Compare September 28, 2020 07:02
@marten-seemann marten-seemann merged commit 471e82f into master Oct 6, 2020
@marten-seemann marten-seemann deleted the fix-post-handshake-message-error-handling branch October 6, 2020 13:29
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants