Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement the limit of unsuccessful decryptions for the AEADs #2771

Merged
merged 2 commits into from
Sep 14, 2020

Conversation

marten-seemann
Copy link
Member

Fixes #2530.

This counts the number of unsuccessful decryption attempts over the lifetime of the connection and closes it once it exceeds the maximum number allowed by the AEAD.

@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #2771 into master will increase coverage by 0.00%.
The diff coverage is 91.67%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2771   +/-   ##
=======================================
  Coverage   86.90%   86.90%           
=======================================
  Files         128      128           
  Lines        9981     9999   +18     
=======================================
+ Hits         8673     8689   +16     
- Misses        980      982    +2     
  Partials      328      328           
Impacted Files Coverage Δ
internal/protocol/protocol.go 100.00% <ø> (ø)
internal/handshake/updatable_aead.go 96.13% <90.00%> (-1.03%) ⬇️
internal/qerr/error_codes.go 100.00% <100.00%> (ø)
qlog/types.go 85.12% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba9f98d...45246da. Read the comment docs.

@marten-seemann marten-seemann merged commit 1914e5f into master Sep 14, 2020
@marten-seemann marten-seemann deleted the aead-limits branch September 14, 2020 09:54
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement the anti-forgery limit
2 participants