Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce the handshake timeout to two minutes in the handshake drop tests #2768

Merged
merged 1 commit into from
Sep 14, 2020

Conversation

marten-seemann
Copy link
Member

That should plenty, and allow CI to not time out.

@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #2768 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2768      +/-   ##
==========================================
+ Coverage   86.67%   86.73%   +0.05%     
==========================================
  Files         128      128              
  Lines       10001    10019      +18     
==========================================
+ Hits         8668     8689      +21     
+ Misses       1006     1004       -2     
+ Partials      327      326       -1     
Impacted Files Coverage Δ
http3/request.go 98.41% <0.00%> (+7.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5a132f...309c578. Read the comment docs.

@marten-seemann marten-seemann force-pushed the reduce-handshake-drop-timeout branch from 0c7f503 to 309c578 Compare September 10, 2020 11:08
@marten-seemann marten-seemann changed the title reduce the handshake timeout to one minute in the handshake drop tests reduce the handshake timeout to two minutes in the handshake drop tests Sep 10, 2020
@marten-seemann marten-seemann merged commit e9906b4 into master Sep 14, 2020
@marten-seemann marten-seemann deleted the reduce-handshake-drop-timeout branch September 14, 2020 07:01
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants