Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip a packet number when sending a 1-RTT PTO packet #2754

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Sep 7, 2020

Fixes #2426.
Depends on #2753.

This will make the peer send an immediate ACK.

@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #2754 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2754   +/-   ##
=======================================
  Coverage   86.72%   86.72%           
=======================================
  Files         128      128           
  Lines       10039    10040    +1     
=======================================
+ Hits         8706     8707    +1     
  Misses       1006     1006           
  Partials      327      327           
Impacted Files Coverage Δ
internal/ackhandler/sent_packet_handler.go 74.79% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9605edd...8ea663d. Read the comment docs.

@marten-seemann marten-seemann force-pushed the skip-packet-number-on-pto branch from 3d517e6 to 8ea663d Compare September 11, 2020 04:17
@marten-seemann marten-seemann merged commit 021b355 into master Sep 11, 2020
@marten-seemann marten-seemann deleted the skip-packet-number-on-pto branch September 11, 2020 05:10
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skip a packet number when sending a PTO
2 participants