Added support for glob patterns #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `a11y` from the command line has glob pattern support but
the grunt plugin was missing this. This is due to the fact that
glob pattern support exists in the cli.js file which is not
exposed as such by the `a11y` module.
So now it should be possible to configure the plugin like this
```js
grunt.initConfig({
a11y: {
dev: {
options: {
urls: ['**/*.html']
}
}
}
});
```
Unit tests showing this was added too using a black-box (and
somewhat crude) approach. I couldn't find a better way of testing
this for now.
|
@peterhaldbaek thanks for your PR. This is a great feature. 👍 |
lucalanca
added a commit
that referenced
this pull request
Oct 19, 2015
Added support for glob patterns
|
Released in 0.1.3 https://github.com/lucalanca/grunt-a11y/releases/tag/0.1.3 |
|
Also adds to documentation: 1315055 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
a11yfrom the command line has glob pattern support butthe grunt plugin was missing this. This is due to the fact that
glob pattern support exists in the cli.js file which is not
exposed as such by the
a11ymodule.So now it should be possible to configure the plugin like this
Unit tests showing this was added too using a black-box (and
somewhat crude) approach. I couldn't find a better way of testing
this for now.