Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recover AST of a declarations file #817

Closed
JohnnyMorganz opened this issue Jan 24, 2023 · 1 comment · Fixed by #860
Closed

Recover AST of a declarations file #817

JohnnyMorganz opened this issue Jan 24, 2023 · 1 comment · Fixed by #860
Assignees
@vegorov-rbx
Labels
enhancement New feature or request

Comments

@JohnnyMorganz
Copy link
Contributor

I want to be able to support documentation comments inlined within a declarations file. For this, I need the AST of the file to be able to find the comments located within it, and attach them to the appropriate functions etc.

Currently, the SourceModule (which contains the AST) created for a declarations file is discarded after its used
@JohnnyMorganz JohnnyMorganz added the enhancement New feature or request label Jan 24, 2023
@JohnnyMorganz JohnnyMorganz mentioned this issue Jan 26, 2023
Open
@vegorov-rbx vegorov-rbx self-assigned this Mar 8, 2023
@vegorov-rbx
Copy link
Collaborator

Should be available in the next sync.

@andyfriesen andyfriesen mentioned this issue Mar 10, 2023
Merged
andyfriesen added a commit that referenced this issue Mar 10, 2023
@andyfriesen @zeux @vegorov-rbx
Sync to upstream/release/567 (#860)
1fa8311 
* Fix #817 
* Fix #850 
* Optimize math.floor/ceil/round with SSE4.1
    * Results in a ~7-9% speedup on the math-cordic benchmark.
* Optimized table.sort.
* table.sort is now ~4.1x faster (when not using a predicate) and ~2.1x
faster when using a simple predicate. Performance may improve further in
the future.
* Reorganize the memory ownership of builtin type definitions.
* This is a small initial step toward affording parallel typechecking.

The new type solver is coming along nicely. We are working on fixing
crashes and bugs.

A few major changes to native codegen landed this week:
* Fixed lowering of Luau IR mod instruction when first argument is a
constant
* Added VM register data-flow/capture analysis
* Fixed issues with optimizations in unreachable blocks

---------

Co-authored-by: Arseny Kapoulkine <[email protected]>
Co-authored-by: Vyacheslav Egorov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vegorov-rbx vegorov-rbx

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sync to upstream/release/567 luau-lang/luau
2 participants
@JohnnyMorganz @vegorov-rbx