Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow leading zeroes in UNSIGNED_INT #87

Closed
nichtich opened this issue Feb 15, 2024 · 1 comment
Closed

Disallow leading zeroes in UNSIGNED_INT #87

nichtich opened this issue Feb 15, 2024 · 1 comment

Comments

@nichtich
Copy link

Change

UNSIGNED_INT
    : [0-9]+
    ;

to

UNSIGNED_INT
    : "0" | [1-9] [0-9]*
    ;
@lszeremeta
Copy link
Owner

Hi, thank you for your suggestion.

You are right. UNSIGNED_INT in YARS-PG is used for cardinalities, datatype precision, and datatype scale. Leading zeros are not needed here, and the allowance to add them may introduce confusion.

I fixed it in 1dea9e3, and I released the YARS-PG 5.0.0 based on semantic versioning ("incompatible API changes").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants