Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show favicon of service #443

Open
stenehall opened this issue Sep 19, 2021 · 6 comments
Open

Show favicon of service #443

stenehall opened this issue Sep 19, 2021 · 6 comments
Labels
area:dashboard The main dashboard page where monitors' status are shown area:status-page Everything related to the status page feature-request Request for new features to be added help wanted May need your help to test or answer

Comments

@stenehall
Copy link

It would be nice if Kuma could attempt to pull the favicon of service added and then show that together with the title.

This could possibly be an additional setting when adding a new moitoring "pull favicon" or even extended to allow upload of icons.

@stenehall stenehall added the feature-request Request for new features to be added label Sep 19, 2021
@louislam
Copy link
Owner

Actually an easy-to-implement feature that I never thought of it.

@louislam louislam added this to the 1.8.0 milestone Sep 19, 2021
@louislam louislam modified the milestones: 1.8.0, 1.9.0 Oct 7, 2021
@pascaliske
Copy link

@louislam Have you already started to build this function? Otherwise I would try ti implement it. 🙂

@louislam
Copy link
Owner

louislam commented Oct 8, 2021

@louislam Have you already started to build this function? Otherwise I would try ti implement it. 🙂

Not yet, but I am still thinking how to implement it, should it be handled in frontend or backend. If it is handled in backend in backend, should it save the favicon.

If you are interested in, feel free to open an empty draft pull request with your idea.

@deefdragon
Copy link
Contributor

I recently had to implement this for another project. Using something like the duckduckgo favicon service and just putting that URL in is probably the fastest & furthest covering way to go.

I would put some filtering in place to check for IP addresses/localhost beforehand to not try to fetch the favicon from those via their service. Those would likely have to be fetched directly or set in the monitor options.

@XHyperDEVX

This comment was marked as spam.

@CommanderStorm
Copy link
Collaborator

Currently, nobody has provided an implementation.

As noted above:

feel free to open an empty draft pull request with your idea

Here is our contribution guide ^^:
https://github.com/louislam/uptime-kuma/blob/03e43ab3643e0f8b610d0ed86b1857675e4e7233/CONTRIBUTING.md

This was referenced Nov 2, 2023
@CommanderStorm CommanderStorm added help wanted May need your help to test or answer area:status-page Everything related to the status page area:dashboard The main dashboard page where monitors' status are shown labels Dec 7, 2023
@louislam louislam removed this from the Pending milestone Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dashboard The main dashboard page where monitors' status are shown area:status-page Everything related to the status page feature-request Request for new features to be added help wanted May need your help to test or answer
Projects
None yet
Development

No branches or pull requests

6 participants