-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show favicon of service #443
Comments
Actually an easy-to-implement feature that I never thought of it. |
@louislam Have you already started to build this function? Otherwise I would try ti implement it. 🙂 |
Not yet, but I am still thinking how to implement it, should it be handled in frontend or backend. If it is handled in backend in backend, should it save the favicon. If you are interested in, feel free to open an empty draft pull request with your idea. |
I recently had to implement this for another project. Using something like the duckduckgo favicon service and just putting that URL in is probably the fastest & furthest covering way to go. I would put some filtering in place to check for IP addresses/localhost beforehand to not try to fetch the favicon from those via their service. Those would likely have to be fetched directly or set in the monitor options. |
This comment was marked as spam.
This comment was marked as spam.
Currently, nobody has provided an implementation. As noted above:
Here is our contribution guide ^^: |
It would be nice if Kuma could attempt to pull the favicon of service added and then show that together with the title.
This could possibly be an additional setting when adding a new moitoring "pull favicon" or even extended to allow upload of icons.
The text was updated successfully, but these errors were encountered: