isPlainObject node 4 vs 6

[AdriVanHoudt]

Hi,

I noticed that using hapijs lodash.isPlainObject(request.query) returns true on node 4 and false on node 6. I know that node 6 changed something (see nodejs/node#6055) but I would suspect it still working.
request.query is being set here https://github.com/hapijs/hapi/blob/master/lib/request.js#L199
I do know request.query is also being validated by Joi so I'm ccing @Marsup to see if he has some insights.

I hope someone knows what's up

[AdriVanHoudt]

So by debugging I got to

lodash/lodash.isplainobject/index.js

Line 135 in 85ca1f4

return (typeof Ctor == 'function' &&

stating typeof Ctor == 'function' is false

[AdriVanHoudt]

Talked to @Marsup and he can't reproduce with Joi so it is probably hapi/node

[jdalton]

Hi @AdriVanHoudt!

If _.isPlainObject is too strict you can also try _.isObject or _.isObjectLike.

[AdriVanHoudt]

@jdalton it is not though, I only want a "pure" object no array or function or string

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.