Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patriotic Eagle Phylum Banishes Can Cause Issues #1990

Open
dsimich opened this issue Jul 31, 2024 · 0 comments
Open

Patriotic Eagle Phylum Banishes Can Cause Issues #1990

dsimich opened this issue Jul 31, 2024 · 0 comments

Comments

@dsimich
Copy link
Member

dsimich commented Jul 31, 2024

Describe the bug
In debugging adding the Patriotic Eagle to Autoscend, I ended the run with the Dude phylum banished. This caused issues going to the Domed City of Grimacia where everything (except dog-aliens) ended up being banished by other banishers, on top of Dudes being banished. Because of the rejection rate of aliens in that zone, I encountered a Tumbleweed which is less than desirable.

To Reproduce
Banish Dudes, or some other necessary phylum

Expected behavior
Though not programmed, I'd expect if specific monsters were desired, that their phyla would be checked against the banished phylum and if the banished phylum was one of the monsters', that garbo would adventure in a zone that has no desired phyla and randomly banish one.

Session Log
Actual error is at the end of the log. Red text is below.
erct657_20240730.txt

JavaScript exception: Error: You lost your most recent combat! Check to make sure everything is alright before rerunning. (file:/C:/Users/dsimi/Downloads/KoLMafia.Updater/scripts/garbage-collector/garbo.js#44031)
at file:/C:/Users/dsimi/Downloads/KoLMafia.Updater/scripts/garbage-collector/garbo.js:44031 (f)
at file:/C:/Users/dsimi/Downloads/KoLMafia.Updater/scripts/garbage-collector/garbo.js:45423 (freeFights)
at file:/C:/Users/dsimi/Downloads/KoLMafia.Updater/scripts/garbage-collector/garbo.js:50254
at file:/C:/Users/dsimi/Downloads/KoLMafia.Updater/scripts/garbage-collector/garbo.js:41499 (withClan)
at file:/C:/Users/dsimi/Downloads/KoLMafia.Updater/scripts/garbage-collector/garbo.js:41493 (withVIPClan)
at file:/C:/Users/dsimi/Downloads/KoLMafia.Updater/scripts/garbage-collector/garbo.js:50235
at file:/C:/Users/dsimi/Downloads/KoLMafia.Updater/scripts/garbage-collector/garbo.js:41478 (withStash)
at file:/C:/Users/dsimi/Downloads/KoLMafia.Updater/scripts/garbage-collector/garbo.js:50234 (main)

Additional context
I don't actually know how much this would affect other users, but phylum banishing is probably useful? Also, once the Eagle is supported in Autoscend, I suspect other people might end up getting this problem and not know what the actual cause was.

@dsimich dsimich changed the title [BUG] Patriotic Eagle Phylum Banishes Can Cause Issues Patriotic Eagle Phylum Banishes Can Cause Issues Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant