-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
back-port: Add RV64 constraint to SRLIW #72155
Comments
/cherry-pick f48dab5 |
@llvm/issue-subscribers-backend-risc-v Author: Erik Kaneda (SchmErik)
Hello, I am trying to get [this](https://github.com//pull/69416) back ported because it fixes [this codegen issue on rv32im targets](https://github.com//issues/69408). We found the issue on Rust version 1.70 and beyond.
I'm new to llvm in general including the llvm release and backport process and would like to backport this commit. On our first attempt of the back porting, we created a PR by commenting on the PR that solved our issue which created this PR. After reading this more carefully, I think the cherry pick comment should have been written on a github issue rather than a PR so I've open this issue to track the back porting of this commit. Again, I'm new to this process so please feel free to let me know if I am missing any info or if there's anything I can do to push the process along. Thanks in advance! |
Error: Command failed due to missing milestone. |
/cherry-pick f48dab5 |
Failed to cherry-pick: f48dab5 https://github.com/llvm/llvm-project/actions/runs/6855180469 Please manually backport the fix and push it to your github fork. Once this is done, please add a comment like this:
|
/cherry-pick f48dab5 |
/branch llvm/llvm-project-release-prs/issue72155 |
/pull-request llvm/llvm-project-release-prs#775 |
@topperc is it possible to backport this to llvm 16 in addition to 17? Codegen for rv32 is broken for this instruction on 16... |
@SchmErik: Only most recent release is maintained. |
Thanks for your response! I'm glad I asked! The reason why I asked was because rust versions that depend on llvm 16 are broken for rv32im so I will take it up with rust maintainers. @nikic I think you're involved in rust's llvm integration. I'll create a separate issue in rust-lang for this but let me know if there's someone else that I should tag! |
@SchmErik All currently supported Rust versions use LLVM 17, not LLVM 16. |
Hello, I am trying to get this back ported because it fixes this codegen issue on rv32im targets. We found the issue on Rust version 1.70 and beyond.
I'm new to llvm in general including the llvm release and backport process and would like to backport this commit. On our first attempt of the back porting, we created a PR by commenting on the PR that solved our issue which created this PR. After reading this more carefully, I think the cherry pick comment should have been written on a github issue rather than a PR so I've open this issue to track the back porting of this commit.
Again, I'm new to this process so please feel free to let me know if I am missing any info or if there's anything I can do to push the process along. Thanks in advance!
The text was updated successfully, but these errors were encountered: