Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebuild filter-line as totally non a11y compliant #72

Open
philli-m opened this issue Aug 23, 2022 · 2 comments
Open

rebuild filter-line as totally non a11y compliant #72

philli-m opened this issue Aug 23, 2022 · 2 comments
Labels
Dev: Refactor issues to be fixed with code refactor Type: Feature-request issue that can be developed into a feature or US

Comments

@philli-m
Copy link
Contributor

filter and sorting elements we use for blog and academy is custom built and is not interpreted by SR's at all, have added label as interim solution but should be rebuilt with as much standard html as possible.
https://stage.liqd.net/en/liquid-academy/
https://stage.liqd.net/en/blog/

@philli-m philli-m added the Dev: Refactor issues to be fixed with code refactor label Aug 25, 2022
@maxliqd maxliqd added this to the release 22 milestone Aug 29, 2022
@philli-m philli-m added Type: Enhancement small improvements to site - less then half story point Type: Feature-request issue that can be developed into a feature or US Type: Question issue or PR needing answer and removed Type: Enhancement small improvements to site - less then half story point Type: Question issue or PR needing answer labels Aug 29, 2022
@philli-m
Copy link
Contributor Author

philli-m commented Aug 29, 2022

@maxliqd refactor issues are a little tricky as it's more a dev reminder then a PM release issue (sorry know that's a bit complicated, will look at improving the descriptions of the labels). Refactoring is normally something we do when we have a US that touches that piece of code and we have the refactor issue as a reminder but re-writing a piece of code without an existing US normally it out of the work scope of an issue have added a feature request tag so it's clearer how much work it'll be.

Also I have already done a hotfix of adding aria-labels, it's just hacky so would be better to refactor when we have to touch this code anyway

@maxliqd maxliqd removed this from the release 22 milestone Aug 29, 2022
@maxliqd
Copy link
Contributor

maxliqd commented Aug 29, 2022

@phillimorland Thanks or the explanation, I really appreciate it! Will remove it from the release 22 milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev: Refactor issues to be fixed with code refactor Type: Feature-request issue that can be developed into a feature or US
Projects
None yet
Development

No branches or pull requests

2 participants