Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll refactor required #1330

Open
philli-m opened this issue Jan 17, 2023 · 3 comments
Open

Poll refactor required #1330

philli-m opened this issue Jan 17, 2023 · 3 comments
Labels
Dev: Refactor issues to be fixed with code refactor

Comments

@philli-m
Copy link
Contributor

React 16 update has exposed issues with state handling in the PollQuestion component.
UseEffect seems to be used only for errors or unchecking, unchecking should not be required if we used checked state correctly. Component has lots of repeat code and is very complex, possible solution to dumb down the question comps and do more in the questions list comp

Screenshot?

@philli-m philli-m added the Dev: Refactor issues to be fixed with code refactor label Jan 17, 2023
@hom3mad3
Copy link
Contributor

hom3mad3 commented Jun 26, 2024

btw @TeaJayyy @goapunk @CarolingerSeilchenspringer

@t-j-q
Copy link

t-j-q commented Jun 27, 2024

@hom3mad3 So the way that interpret it, this means that the code of PollQuestion is in itself not optimal and needs to be revised before we think about changing certain aspects of the poll module, right?

@hom3mad3
Copy link
Contributor

hom3mad3 commented Jun 27, 2024

@hom3mad3 So the way that interpret it, this means that the code of PollQuestion is in itself not optimal and needs to be revised before we think about changing certain aspects of the poll module, right?

The entire poll needs refactoring. This includes not just the PollQuestion component, but all the other components that are dependencies of Poll as well.

@CarolingerSeilchenspringer CarolingerSeilchenspringer added this to the Poll milestone Jul 10, 2024
@t-j-q t-j-q removed this from the Poll milestone Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev: Refactor issues to be fixed with code refactor
Projects
None yet
Development

No branches or pull requests

4 participants