Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add left/right padding to the main window #360

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hualet
Copy link
Contributor

@hualet hualet commented Sep 20, 2024

add left/right padding to the main window, or it looks like the term content is cut.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hualet

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

void setColorScheme(const QString &name);


void updateBackgroundColor();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

得用这个替换setColorScheme才能实现是吗?

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Oct 31, 2024

TAG Bot

New tag: 6.0.15
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #365

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Nov 29, 2024

TAG Bot

New tag: 6.0.16
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #367

add left/right padding to the main window, or it looks like the
term content is cut.
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • QTermWidget::backgroundColor函数中,当table为空时返回默认颜色,但未处理table[DEFAULT_BACK_COLOR]可能为空的情况。
  • TermWidgetPage::updateBackgroundColor函数中,currentTerminal()可能返回空指针,应进行空指针检查。
  • TermWidgetPage::updateBackgroundColor函数中,Settings::instance()->opacity()可能返回无效值,应进行有效性检查。
  • TermWidgetPage::updateBackgroundColor函数中,setPalettesetAutoFillBackground的使用可能不正确,应确保背景颜色的设置是有效的。

是否建议立即修改:

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Dec 16, 2024

TAG Bot

New tag: 6.0.17
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants