-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add -C option to enable Compress #261
base: master
Are you sure you want to change the base?
Conversation
shenmo7192
commented
Mar 11, 2023
- feat: enable compress when ssh connect. This is very useful when ssh x forwarding
* feat: enable compress when ssh connect. This is very useful when ssh x forwarding
Thank you for your contribution.
Compression is desirable on modem lines and other slow connections, but will only slow down things on fast net To my understanding, it would be much better if it can be implemented as an optional setting. |
I think the compression perform loss is totally acceptable in modern computers, so I think it can be a default. Also the compression makes it possible to use X11 forwarding on not so good network. |
-1. It's a burden for lower end boxes, VPS, development boards etc. Hardcoding to force-enable it is not acceptable here. Please consider utilizing existing ssh_config mechanism, i.e. setting "Compression yes" yourself in either ~/.ssh/config or /etc/ssh/ssh_config either for all hosts, or individually for specific hosts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoding is not acceptable here.
TAG Bot New tag: 5.9.47 |
TAG Bot New tag: 5.9.48 |
TAG Bot New tag: 5.9.49 |
TAG Bot New tag: 6.0.10 |
TAG Bot New tag: 6.0.11 |
TAG Bot New tag: 6.0.12 |
TAG Bot New tag: 6.0.13 |
TAG Bot New tag: 6.0.14 |
TAG Bot New tag: 6.0.15 |
TAG Bot New tag: 6.0.16 |
TAG Bot New tag: 6.0.17 |