Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected language in settings resets when changing pages #56

Open
pushkar707 opened this issue Mar 7, 2024 · 4 comments
Open

Selected language in settings resets when changing pages #56

pushkar707 opened this issue Mar 7, 2024 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@pushkar707
Copy link
Contributor

Screenshot (21)

Issue: A lot of time the language set by the user for the extension gets reset, this behavior is seen usually when we open a new tab or just navigate through various URLs in the website.

Reproduction: Change the default language of the extension to any language (English in my case), and just use the browser normally, and keep checking the extension popup's language. You will be very quickly able to see the language change.

My System:
OS: Windows 11 with WSL (Ubuntu 20.04)

@hugolpz hugolpz changed the title Extension langauge needs gets reset on when changing pages Extension language needs gets reset on when changing pages Mar 11, 2024
@hugolpz
Copy link
Member

hugolpz commented Mar 11, 2024

@pushkar707 thank for this issue I was not aware of. Settings are stored in some local storage, so I'm a bit surprised. You are not in some Incognito mode which may remove local storages ?

@pushkar707
Copy link
Contributor Author

No, I ran the extension in Firefox browser, through "npm run web-ext:test" command

@pushkar707
Copy link
Contributor Author

I think this was an issue on my end only, I will confirm it and close this.

@hugolpz
Copy link
Member

hugolpz commented Mar 12, 2024

@pushkar707 , I assigned you this task since you are leading it as well and (finger crossed 🤞🏼 ) it will self-solve.

@hugolpz hugolpz added the bug Something isn't working label Mar 12, 2024
@hugolpz hugolpz added this to the Far away milestone May 23, 2024
@hugolpz hugolpz changed the title Extension language needs gets reset on when changing pages Extension language resets when changing pages Jun 9, 2024
@hugolpz hugolpz changed the title Extension language resets when changing pages Selected language in settings resets when changing pages Jun 9, 2024
@hugolpz hugolpz closed this as completed Jun 9, 2024
@hugolpz hugolpz reopened this Jun 9, 2024
@kabir-afk kabir-afk mentioned this issue Jun 14, 2024
@hugolpz hugolpz modified the milestones: Far away, Fall 2024 Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants