Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to manifest.json v3.0 #21

Closed
6 tasks done
hugolpz opened this issue Aug 4, 2022 · 4 comments
Closed
6 tasks done

Migrate to manifest.json v3.0 #21

hugolpz opened this issue Aug 4, 2022 · 4 comments
Assignees
Labels
help wanted Extra attention is needed
Milestone

Comments

@hugolpz
Copy link
Member

hugolpz commented Aug 4, 2022

This actually implies to do a bunch of code migration, with async, etc.

Chrome's migration checklist

Chrome provides a migration checklist which points to more actionable resources :

V3 from scratch ?

Resources

Related

@hugolpz hugolpz added the help wanted Extra attention is needed label Aug 4, 2022
@hugolpz hugolpz changed the title Load background-script.js into SignItCoreContent.js Migrate to manifest.json v3.0 Aug 20, 2022
@hugolpz hugolpz added the good first issue Good for newcomers label Aug 20, 2022
@kabir-afk kabir-afk self-assigned this Jan 12, 2024
@hugolpz
Copy link
Member Author

hugolpz commented Apr 30, 2024

You can now use both when coding and testing locally, thank to YujiSoftware:

"background": {
    "service_worker": "background.js",
    "scripts": ["background.js"]
},

EDIT: remove "scripts": ["background.js"] when packaging your webext for Chrome Web store. Thank to wolfmanstout for this hint.

Source: mozilla/web-ext#2532 (comment)

@kabir-afk
Copy link
Collaborator

Mind reviewing the PR if you are free now😅,I mentioned the same under "Additional Info on Cross browser background scripts"😅

@kabir-afk kabir-afk added this to the GSoC 2024 milestone May 23, 2024
@hugolpz hugolpz closed this as completed Jun 9, 2024
@hugolpz hugolpz closed this as completed Jun 9, 2024
@hugolpz hugolpz reopened this Jun 9, 2024
@kabir-afk
Copy link
Collaborator

kabir-afk commented Jun 10, 2024

When migrating to service worker , we have to convert timers to alarms as well. And under Updating API calls we have to convert callbacks to Promises. I haven't converted timers to alarms yet and I haven't looked upon the latter.

  • converted timers to alarms

@kabir-afk kabir-afk removed the good first issue Good for newcomers label Jun 20, 2024
@hugolpz
Copy link
Member Author

hugolpz commented Jul 20, 2024

I close this. We consider it done since is works correctly with MV3 approach.

If Chrome / Firefox stores requests changes, it will be to adapt to those stores' requirements, and new issues must be open.

@hugolpz hugolpz closed this as completed Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants