Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run-time errors after release of v2.4.1 #56

Closed
thinkh opened this issue May 6, 2022 · 0 comments · Fixed by #57
Closed

Run-time errors after release of v2.4.1 #56

thinkh opened this issue May 6, 2022 · 0 comments · Fixed by #57
Assignees
Labels

Comments

@thinkh
Copy link
Member

thinkh commented May 6, 2022

LineUp breaks in our apps after the release 2.4.1 with the following run-time error:

Uncaught (in promise) TypeError: Class constructor ACellTableSection cannot be invoked without 'new'
    at new EngineRanking (EngineRanking.js:71:1)
    at MultiTableRowRenderer.<anonymous> (EngineRenderer.js:277:1)
    at MultiTableRowRenderer.pushTable (MultiTableRowRenderer.js:107:1)
    at EngineRenderer.push.6NJj.EngineRenderer.addRanking (EngineRenderer.js:276:1)
    at Object.<anonymous> (EngineRenderer.js:225:1)
    at Dispatch.apply (dispatch.js:61:59)
    at fireImpl (AEventDispatcher.js:107:1)
    at Array.forEach (<anonymous>)
    at LocalDataProvider.push.gwz5.AEventDispatcher.fireImpl (AEventDispatcher.js:110:1)
    at LocalDataProvider.push.gwz5.AEventDispatcher.fire (AEventDispatcher.js:84:1)

image

I think the error is caused by the updated tsconfig.json. We should revert/downgrade version and match the one in lineupjs.

"compilerOptions": {
"module": "ES2020",
"target": "ES2019",
"importHelpers": false,
"sourceMap": true,
"lib": ["DOM", "ES2019"],

https://github.com/lineupjs/lineupjs/blob/93e18c26a61797342b4953a2d6b6a9558ce4a177/tsconfig.json#L3-L7

    "module": "ES2015",
    "target": "ES5",
    "importHelpers": false,
    "sourceMap": true,
    "lib": ["DOM", "ES2015", "es2016.array.include", "es2017.object"],

Please create another patch release after this fix.

Context

@thinkh thinkh added the bug label May 6, 2022
@thinkh thinkh linked a pull request May 6, 2022 that will close this issue
3 tasks
@thinkh thinkh assigned thinkh and unassigned sgratzl May 6, 2022
@sgratzl sgratzl closed this as completed in a57b5f2 May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants