Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: revert changes in x/slashing proto #627

Merged
merged 13 commits into from
Aug 10, 2022
Merged

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Aug 4, 2022

Description

closes: #616

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech self-assigned this Aug 4, 2022
@0Tech 0Tech changed the title Revert changes in x/slashing proto refactor: revert changes in x/slashing proto Aug 4, 2022
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #627 (d557828) into main (fed352c) will increase coverage by 0.04%.
The diff coverage is 61.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #627      +/-   ##
==========================================
+ Coverage   60.18%   60.23%   +0.04%     
==========================================
  Files         817      817              
  Lines       94996    95000       +4     
==========================================
+ Hits        57178    57219      +41     
+ Misses      34359    34325      -34     
+ Partials     3459     3456       -3     
Impacted Files Coverage Δ
simapp/export.go 12.59% <0.00%> (ø)
x/slashing/types/signing_info.go 0.00% <0.00%> (ø)
x/slashing/client/testutil/suite.go 97.84% <100.00%> (+0.01%) ⬆️
x/slashing/keeper/hooks.go 80.00% <100.00%> (+0.51%) ⬆️
x/slashing/keeper/infractions.go 85.14% <100.00%> (+0.14%) ⬆️
x/token/validation.go 90.90% <0.00%> (-1.82%) ⬇️
x/foundation/foundation.go 73.64% <0.00%> (+1.80%) ⬆️
x/collection/msgs.go 39.62% <0.00%> (+2.77%) ⬆️
x/token/msgs.go 34.51% <0.00%> (+4.06%) ⬆️
x/foundation/msgs.go 44.71% <0.00%> (+4.32%) ⬆️
... and 1 more

@0Tech 0Tech requested review from zemyblue and dudong2 August 4, 2022 08:45
@0Tech 0Tech marked this pull request as ready for review August 4, 2022 08:45
x/slashing/keeper/signing_info_test.go Show resolved Hide resolved
x/slashing/handler_test.go Show resolved Hide resolved
x/slashing/keeper/keeper_test.go Outdated Show resolved Hide resolved
x/slashing/keeper/keeper_test.go Outdated Show resolved Hide resolved
proto/cosmos/slashing/v1beta1/slashing.proto Outdated Show resolved Hide resolved
simapp/export.go Show resolved Hide resolved
x/slashing/handler_test.go Show resolved Hide resolved
x/slashing/handler_test.go Show resolved Hide resolved
@0Tech 0Tech merged commit ddc1d4e into Finschia:main Aug 10, 2022
@0Tech 0Tech deleted the slashing branch August 10, 2022 02:31
zemyblue added a commit that referenced this pull request Sep 5, 2022
* main:
  fix: wasm module's FIXME in the snapshotter.go file (#649)
  chore(deps): Bump actions/setup-go from 3.2.1 to 3.3.0 (#650)
  chore(deps): Bump actions/cache from 3.0.7 to 3.0.8 (#648)
  fix: remove legacy codes of wasm (#640)
  chore(deps): Bump github.com/mattn/go-isatty from 0.0.14 to 0.0.16 (#643)
  chore(deps): Bump actions/cache from 3.0.6 to 3.0.7 (#642)
  chore: change some minor things that haven't been fixed in #549 (#635)
  refactor: rename x/collection events (#639)
  feat: add additional fields into x/collection events (#638)
  refactor: rename x/token events (#637)
  feat: add creator into x/token EventIssue (#636)
  chore(deps): Bump github.com/coinbase/rosetta-sdk-go (#641)
  chore: change `Keeper.space` type to be same with cosmos-sdk
  refactor: remove SetBalance and SetSupply (#629)
  refactor: revert changes in x/slashing proto (#627)
  chore(deps): Bump actions/cache from 3.0.5 to 3.0.6 (#631)
  chore(deps): Bump github.com/prometheus/client_golang (#632)
  chore(deps): Bump actions/setup-go from 2.1.4 to 3.2.1 (#624)
  feat: add Query/TokenClassTypeName (#622)
  feat: add additional information into EventXXXChanged (#621)

Signed-off-by: zemyblue <[email protected]>

# Conflicts:
#	CHANGELOG.md
#	client/docs/statik/statik.go
#	simapp/app.go
#	x/wasm/types/events.go
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimize the differences between x/slashing and its upstream's
3 participants