Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply change of prefix of key name in ostracon #610

Merged
merged 3 commits into from
Jul 27, 2022

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Jul 26, 2022

Description

Apply the changes to change the prefixs of key name in ostracon.
Finschia/ostracon#447

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@zemyblue zemyblue marked this pull request as draft July 26, 2022 13:24
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #610 (af6f242) into main (869c7e7) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #610      +/-   ##
==========================================
+ Coverage   59.70%   59.74%   +0.04%     
==========================================
  Files         811      811              
  Lines       94491    94491              
==========================================
+ Hits        56419    56457      +38     
+ Misses      34623    34559      -64     
- Partials     3449     3475      +26     
Impacted Files Coverage Δ
crypto/keys/ed25519/ed25519.go 76.13% <ø> (ø)
crypto/keys/multisig/codec.go 100.00% <ø> (ø)
crypto/keys/secp256k1/secp256k1.go 88.63% <ø> (ø)
crypto/ledger/amino.go 100.00% <100.00%> (ø)
x/token/validation.go 72.72% <0.00%> (-12.73%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 82.45% <0.00%> (-1.76%) ⬇️
x/foundation/foundation.go 74.72% <0.00%> (+1.44%) ⬆️
x/foundation/msgs.go 37.98% <0.00%> (+1.92%) ⬆️
x/token/msgs.go 39.08% <0.00%> (+2.53%) ⬆️
x/collection/msgs.go 39.81% <0.00%> (+5.18%) ⬆️
... and 2 more

@zemyblue zemyblue changed the title feat: apply the changes to change the prefixs of key name in ostracon. feat: apply change of prefix of key name in ostracon Jul 26, 2022
@zemyblue zemyblue marked this pull request as ready for review July 27, 2022 05:36
@zemyblue zemyblue requested review from dudong2, 0Tech and tnasu July 27, 2022 05:36
@zemyblue zemyblue self-assigned this Jul 27, 2022
@zemyblue zemyblue merged commit 97baddf into Finschia:main Jul 27, 2022
dudong2 pushed a commit to dudong2/lbm-sdk that referenced this pull request Aug 1, 2022
* feat: apply the changes to change the prefixs of key name in ostracon.

Signed-off-by: zemyblue <[email protected]>

* chore: update ostracon version

Signed-off-by: zemyblue <[email protected]>

* chore: update changelog

Signed-off-by: zemyblue <[email protected]>
@zemyblue zemyblue deleted the change_keyname_of_ostracon branch August 2, 2022 11:49
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants