-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change amino codec path from lbm-sdk/
to cosmos-sdk/
#600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zemyblue <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #600 +/- ##
==========================================
+ Coverage 57.63% 60.59% +2.95%
==========================================
Files 797 815 +18
Lines 87546 95015 +7469
==========================================
+ Hits 50456 57572 +7116
- Misses 33959 34185 +226
- Partials 3131 3258 +127
|
Signed-off-by: zemyblue <[email protected]>
0Tech
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Youngtaek Yoon <[email protected]>
dudong2
approved these changes
Jul 19, 2022
tnasu
approved these changes
Jul 19, 2022
torao
approved these changes
Jul 19, 2022
torao
pushed a commit
to torao/finschia-sdk
that referenced
this pull request
Jul 19, 2022
…hia#600) * feat: change amino codec path from `lbm-sdk/` to `cosmos-sdk/` Signed-off-by: zemyblue <[email protected]> * chore: add changelog. Signed-off-by: zemyblue <[email protected]> * Update CHANGELOG.md Co-authored-by: Youngtaek Yoon <[email protected]> Co-authored-by: Youngtaek Yoon <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
change legacy
amino
codec path fromlbm-sdk/
tocosmos-sdk/
Below modules's codec path are changed.
auth
bank
crisis
distribution
evidence
gov
ibc
params
slashig
upgrade
Motivation and context
Change the gRPC path to the path of the original cosmos-sdk was completed in #564 , but legacy
amino
still haslbm-sdk
as the path, so I modify it.How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml