-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: publish docker image on tag push #469
Conversation
This reverts commit 2f305c4.
I have confirmed it working. |
Could you add the release version as a tag when merge a release PR? |
I think it's possible, let me change the condition. But I think it would be better to create "release" after we confirmed the docker image works. It means we should push the image before the "release". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It makes CI to publish the docker image on tag pushes.
Description
It adds a workflow which publishes the docker image on tag push event.
The destination is docker.io/line/lbm-simapp for now.
The image tag would be the corresponding semver and
latest
.closes: #455
Motivation and context
Refer to #455
How has this been tested?
The PR will trigger the workflow. And I confirmed it works, I will revert the commit which triggers the workflow on PR.
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml
[no need]