Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIN_RELAY_FEE_SAT_PER_1000_WEIGHT is inflated 16x #3438

Open
morehouse opened this issue Dec 3, 2024 · 2 comments
Open

MIN_RELAY_FEE_SAT_PER_1000_WEIGHT is inflated 16x #3438

morehouse opened this issue Dec 3, 2024 · 2 comments
Assignees
Milestone

Comments

@morehouse
Copy link
Contributor

MIN_RELAY_FEE_SAT_PER_1000_WEIGHT is used to enforce a minimum fee bump for transaction RBFs. Per Bitcoin Core policy, this should be 1 sat/vB. Instead, we're using 16 sat/vB:

/// Minimum relay fee as required by bitcoin network mempool policy.
pub const MIN_RELAY_FEE_SAT_PER_1000_WEIGHT: u64 = 4000;

This causes RBFs to be much larger than needed in some cases.

We should be using 250 sat/kw, or maybe 253 sat/kw if we need to worry about rounding for the incremental relay feerate.

@TheBlueMatt
Copy link
Collaborator

Oof good catch.

@TheBlueMatt TheBlueMatt added this to the 0.1 milestone Dec 3, 2024
@arik-so arik-so self-assigned this Dec 5, 2024
@TheBlueMatt
Copy link
Collaborator

If this makes 0.1, great, if it doesn't, well, its not a regression nor a new feature, it generally takes users a week or two to upgrade anyway, and we can include this in 0.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants