Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add payment_id field to PaymentForwarded event. #3409

Open
G8XSU opened this issue Nov 14, 2024 · 0 comments
Open

Add payment_id field to PaymentForwarded event. #3409

G8XSU opened this issue Nov 14, 2024 · 0 comments

Comments

@G8XSU
Copy link
Contributor

G8XSU commented Nov 14, 2024

Currently, PaymentForwarded event doesn't have a payment_id or an idempotency-id field and there can be duplicate events for the same forwarded htlc in case of some edge cases around restarts.
This may render all the metrics related to forwarding fees, etc., unreliable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@G8XSU