Take circular GossipVerifier reference by Arc
#3432
Conversation
Our current architecture requires `GossipVerifier`'s type signature to include a circular reference to itself. Previously, we directly gave that as `Self`, which however did not work when setting it dynamically under all circumstances. Here we take `Self` by `Arc` mitigate this issue.
|
After all the back-and-forth on that issue I'm kinda of the opinion that we should do #3369 (comment) instead |
Hmm, I still kind of dislike this from an architectural standpoint. FWIW, some users recently also discovered that in a remote-storage world, it makes a lot of sense to keep the network graph in a separate (potentially ephemeral) local cache, not it the main store. The message queue probably won't get persisted at all of course, but I fear that if we start walking down that line of putting more and more things into the But maybe I'm still misunderstanding what you're proposing? |
|
No, I mean I agree, its definitely not ideal to make |
Closes #3369.
Our current architecture requires
GossipVerifier's type signature to include a circular reference to itself. Previously, we directly gave that asSelf, which however did not work when setting it dynamically under all circumstances. Here we takeSelfbyArcmitigate this issue.This change was proposed by @TheBlueMatt in #3369 (comment), I have yet to confirm it works as expected myself.