Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New page settings in IPFS.json #542

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from

Conversation

ev-d
Copy link

@ev-d ev-d commented Nov 11, 2024

Description

Added a new pages section in IPFS.json config section
Initial pages structure

  // Describe current pages
  export type ManifestConfigPage =
  | '/'
  | '/wrap'
  | '/withdrawals'
  | '/rewards'
  | '/settings'
  | '/referral';
  
  // IPFS.json structure
  pages?: {
    [page in ManifestConfigPage]?: {
      shouldDisable?: boolean;
      sections?: [string, ...string[]];
    };
  }

shouldDisable - describes page availability state, default false and page is shown
sections - describes which page's sections are disabled, default all sections are available

Note: current updates impact on Sepolia network

Testing notes

For local testing, set default chain to 11155111

Checklist:

  • Checked the changes locally.
  • Created / updated analytics events.
  • Created / updated the technical documentation (README.md / docs / etc.).
  • Affects / requires changes in other services (Matomo / Sentry / CloudFlare / etc.).

@ev-d ev-d requested review from a team as code owners November 11, 2024 16:39
@preview-stands
Copy link

preview-stands bot commented Nov 11, 2024

Preview stand status

Preview stand available on testnet

@ev-d ev-d changed the title [WIP] new page settings in IPFS.json New page settings in IPFS.json Nov 12, 2024
@ev-d ev-d requested a review from Jeday December 1, 2024 22:02
utilsApi/get-default-static-props.ts Outdated Show resolved Hide resolved
config/external-config/types.ts Outdated Show resolved Hide resolved
providers/external-forbidden-route.tsx Outdated Show resolved Hide resolved
@ev-d ev-d requested a review from Jeday December 2, 2024 20:22
config/external-config/utils.ts Outdated Show resolved Hide resolved
config/external-config/types.ts Outdated Show resolved Hide resolved
config/external-config/utils.ts Outdated Show resolved Hide resolved
providers/external-forbidden-route.tsx Outdated Show resolved Hide resolved
utilsApi/fetch-external-manifest.ts Outdated Show resolved Hide resolved
config/external-config/types.ts Outdated Show resolved Hide resolved
config/external-config/types.ts Outdated Show resolved Hide resolved
Jeday
Jeday previously approved these changes Dec 11, 2024
@ev-d ev-d requested a review from Jeday December 11, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants