Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GossipSub] Make sure no duplicates are sent to the same peer #370

Open
Nashatyrev opened this issue Jul 9, 2024 · 1 comment
Open

[GossipSub] Make sure no duplicates are sent to the same peer #370

Nashatyrev opened this issue Jul 9, 2024 · 1 comment

Comments

@Nashatyrev
Copy link
Collaborator

Summary

It could potentially be the case when a message was propagated to a peer and we then receive IWANT from the same peer asking for the same message.
We should at least add a unit test for this case

Expected behavior

No duplicates

Actual behavior

Probably duplicate

Relevant log output

No response

Possible Solution

No response

Version

No response

Would you like to work on fixing this bug ?

Maybe
@Nashatyrev
Copy link
Collaborator Author

Has been highlighted here: https://ethresear.ch/t/number-duplicate-messages-in-ethereums-gossipsub-network/19921/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Nashatyrev