Skip to content
This repository has been archived by the owner on Sep 10, 2022. It is now read-only.

tests failing on Go 1.15 due to int -> string conversion #68

Closed
marten-seemann opened this issue Dec 17, 2020 · 0 comments · Fixed by #69
Closed

tests failing on Go 1.15 due to int -> string conversion #68

marten-seemann opened this issue Dec 17, 2020 · 0 comments · Fixed by #69
Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws)

Comments

@marten-seemann
Copy link
Contributor

For example:

./listener_test.go:45:57: conversion from untyped int to ID (string) yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
@marten-seemann marten-seemann added kind/bug A bug in existing code (including security flaws) exp/novice Someone with a little familiarity can pick up labels Dec 17, 2020
@marten-seemann marten-seemann mentioned this issue Dec 17, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix int to string conversion in tests, update Go version on CI libp2p/go-libp2p-transport-upgrader
1 participant
@marten-seemann