Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLACEHOLDER] Golang Gossipsub profiling and optimisation #7

Open
raulk opened this issue Aug 5, 2019 · 3 comments
Open

[PLACEHOLDER] Golang Gossipsub profiling and optimisation #7

raulk opened this issue Aug 5, 2019 · 3 comments
Assignees
Labels
Complexity: Hard Language: Go To be developed in Golang Priority: P0 Top priority Ready for work: Yes Selected: ETHBerlinZwei Project selected for ETHBerlinZwei (https://ethberlinzwei.com) Status: Proposed

Comments

@raulk
Copy link
Member

raulk commented Aug 5, 2019

Motivation and context

The current golang implementation of gossipsub is a reference implementation:

https://github.com/libp2p/go-libp2p-pubsub

It is intended to be correct and fully implement the protocol, but it is by no means optimized.

This leaves a lot of room for improvement in terms of performance; this more generally applies to the go-libp2p pubsub implementation.

We want to improve the reference implementation and make sure it is production-quality, so that it can be used in production environments without any fear or performance concerns.

Value

Benefits (if addressed)

ETH2 implementers can rely on a reference implementation to be used in production without any performance concerns.

Risks (if not addressed)

We are not addressing potential performance problems, which may cause issues in production.

Expected output and constraints

Relevant discussion

Design/implementation notes

Potential funders

@vyzo
Copy link

vyzo commented Aug 13, 2019

added a little bit of detail.

@daviddias
Copy link
Member

@raulk @momack2 is this grant still relevant after the work done in https://blog.ipfs.io/gossipsubv1.1-eval-report-and-security-audit/ ?

@momack2
Copy link

momack2 commented Jul 29, 2020

Happy to deprecate this grant - agree I think the main aim was accomplished now 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Hard Language: Go To be developed in Golang Priority: P0 Top priority Ready for work: Yes Selected: ETHBerlinZwei Project selected for ETHBerlinZwei (https://ethberlinzwei.com) Status: Proposed
Projects
None yet
Development

No branches or pull requests

4 participants