Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MDNS discovery in go per the new spec #11

Open
Stebalien opened this issue Aug 5, 2019 · 7 comments
Open

Implement MDNS discovery in go per the new spec #11

Stebalien opened this issue Aug 5, 2019 · 7 comments
Assignees
Labels
Complexity: Medium Kind: Proposal Language: Go To be developed in Golang Language: JS Priority: P1 High priority Ready for work: Yes Selected: ETHBerlinZwei Project selected for ETHBerlinZwei (https://ethberlinzwei.com) Status: Proposed

Comments

@Stebalien
Copy link
Member

Stebalien commented Aug 5, 2019

This project is specified here: 011-mdns-go-js.md.

@vasco-santos
Copy link
Member

I agree with implementing MDNS discovery according to the new spec should be a priority.

Other than go, the same should happen for JS, also aiming to get the interoperable side of things.

@Stebalien @raulk I think we could include JS in this issue, what do you think? Otherwise, I can create a new issue to track JS.

@raulk
Copy link
Member

raulk commented Aug 7, 2019

@vasco-santos - I've added the JS label to this issue now.

@Stebalien
Copy link
Member Author

Other than go, the same should happen for JS, also aiming to get the interoperable side of things.

I thought js already implemented the new spec. Is that not the case?

@jacobheun
Copy link
Contributor

No, a compatibility layer was added a few months ago to get interop functioning with go. Ideally we'd get both implemented together and scrap all of that shenanigans.

@Stebalien
Copy link
Member Author

Ah, so JS implements one thing, Go implements another, and the spec specifies a third? I guess we finally have a real spec.

@vasco-santos
Copy link
Member

Ah, so JS implements one thing, Go implements another, and the spec specifies a third? I guess we finally have a real spec.

Yeah, that's the current state of things

@semtexzv
Copy link

Rust implementation implements the spec. Go & JS implementations do not.
libp2p/rust-libp2p#1678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Kind: Proposal Language: Go To be developed in Golang Language: JS Priority: P1 High priority Ready for work: Yes Selected: ETHBerlinZwei Project selected for ETHBerlinZwei (https://ethberlinzwei.com) Status: Proposed
Projects
None yet
Development

No branches or pull requests

5 participants