Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port JTS BoundaryChainNoder to make CoverageUnion faster #638

Closed
dr-jts opened this issue Jun 17, 2022 · 1 comment
Closed

Port JTS BoundaryChainNoder to make CoverageUnion faster #638

dr-jts opened this issue Jun 17, 2022 · 1 comment
Labels
Enhancement New feature or feature improvement.

Comments

@dr-jts
Copy link
Contributor

dr-jts commented Jun 17, 2022

See locationtech/jts#891. The JTS BoundaryChainNoder makes polygon coverage union faster, by reducing memory allocation and topology graph complexity.

This can be ported as-is, to work with OverlayNG CoverageUnion.

The technique could also be used in the Polygonizer-based CoverageUnion (by @dbaston)

It is worth exploring if the approach to detecting duplicate segments can be optimized further, perhaps by:

  • use a SegmentView-style facade class, to avoid copying coordinates
  • use a vector-based "sort/remove dups", rather than using a unordered_set.
@dr-jts dr-jts added the Enhancement New feature or feature improvement. label Jun 17, 2022
@dr-jts dr-jts changed the title Port JTS BoundaryChainNoder Port JTS BoundaryChainNoder to make CoverageUnion faster Jun 17, 2022
@brendan-ward brendan-ward mentioned this issue Jun 21, 2022
Closed
@pramsey
Copy link
Member

pramsey commented Aug 15, 2022

This happened in #655

@pramsey pramsey closed this as completed Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or feature improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pramsey @dr-jts