Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update or Fix AsciiParser::species_list() #262

Open
pbauman opened this issue Jul 10, 2018 · 0 comments
Open

Update or Fix AsciiParser::species_list() #262

pbauman opened this issue Jul 10, 2018 · 0 comments

Comments

@pbauman
Copy link
Member

pbauman commented Jul 10, 2018

I guess we're supposed to provide just a file with a new species on each line? Since we still require the species_data, we could just parse the first column of that file. Downside is not leveraging default file Antioch has, but upside is one fewer text files the user needs to parse for the AsciiParser. My preference is the latter (especially after trying to lay all these parsing hooks into GRINS, it's nice to have just one file, ala Cantera/XML).

This is not high priority because really I just want to prefer XML, but ChemKin won't be hard to support either, but at least wanted to log it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant